I'll split this patch in one patch for file and resend. On Wed, Sep 12, 2012 at 10:06 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Tue, Sep 11, 2012 at 08:00:32PM +0200, Peter Senna Tschudin wrote: >> diff --git a/drivers/media/dvb-frontends/lg2160.c b/drivers/media/dvb-frontends/lg2160.c >> index cc11260..748da5d 100644 >> --- a/drivers/media/dvb-frontends/lg2160.c >> +++ b/drivers/media/dvb-frontends/lg2160.c >> @@ -1451,7 +1451,6 @@ struct dvb_frontend *lg2160_attach(const struct lg2160_config *config, >> return &state->frontend; >> fail: >> lg_warn("unable to detect LG216x hardware\n"); >> - kfree(state); >> return NULL; >> } > > I wish you had fixed this the same as the others and removed the > goto. Also the printk is redundant and wrong. Remove it too. > > regards, > dan carpenter > -- Peter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html