On Wed, Sep 12, 2012 at 10:28:13AM +0800, Fengguang Wu wrote: > Hi Aristeu, > > FYI, there are new smatch warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next > head: 9814e970d7947dcc5ab7b37a53514c0098bfacc9 > commit: 38f38657444d15e1a8574eae80ed3de9f501737a xattr: extract simple_xattr code from tmpfs > > > fs/xattr.c:882 __simple_xattr_set() error: potential NULL dereference 'new_xattr'. > I don't know if this specific code is buggy or not. It would depend on how the function is called. But potentially I should disable this Smatch rule. It tends to have a lot of false positives. The thing is that GCC complains if you don't initialize "new_xattr", but if you initialize it to NULL then Smatch complains. One solution might be to use the unitialized_var() macro. - struct simple_xattr *new_xattr = NULL; + struct simple_xattr *uninitialized_var(new_xattr); That would make both GCC and Smatch happy. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
