> > I think the intention of the warning is that the err value from > > lm3530_init_registers() can be directly returned, like this: > > > > err = lm3530_init_registers(drvdata); > > if (err < 0) { > > dev_err(&client->dev, > > "Register Init failed: %d\n", err); > > - return -ENODEV; > > + return err; > > } > > > > That will remove the assumption that lm3530_init_registers() always > > returns -ENODEV on error. > > Oh OK. Now I got it :) > Thanks for the clarification. > Since this was a prevalent issue with this driver (and maybe with > other driver too?), I will send a patch to fix this up. Yes, I think so.. Thank you very much! Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html