Hi Bernd, > > -#define MAX_LEVEL (MAX_ID_SHIFT + IDR_BITS - 1) / IDR_BITS > > +#define MAX_ID_LEVEL (MAX_ID_SHIFT + IDR_BITS - 1) / IDR_BITS > > And while you are it: Please add '(' and ')' around it as in > > #define MAX_ID_LEVEL ((MAX_ID_SHIFT + IDR_BITS - 1) / IDR_BITS) Good idea. Done. > > > /* Number of id_layer structs to leave in free list */ > > -#define IDR_FREE_MAX MAX_LEVEL + MAX_LEVEL > > +#define IDR_FREE_MAX MAX_ID_LEVEL + MAX_ID_LEVEL > #define IDR_FREE_MAX (MAX_ID_LEVEL + MAX_ID_LEVEL) > > For starters (sleeping in "cpp-101";-): People may use it as in > "IDR_FREE_MAX * 2". > And I didn't look into that file - that should be changed everywhere in > that way. Sure. It's the only place that need change. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html