Re: [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefencing uninitialized 'pci_handle'.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 09, 2012 at 08:19:39PM +0800, Fengguang Wu wrote:
> Hi Matthew,
> 
> FYI, there are new smatch warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
> head:   97ac9d1f363964dec7fbb20cf3c2e88336b4d801
> commit: 66f2adcdadea18a583d4f7cbd773847d635731a3 [73/77] EFI: Stash ROMs if they're not in the PCI BAR
> 
> All smatch warnings:
> 
> + arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefencing uninitialized 'pci_handle'.

These warnings probably have too high of a false positive rate to be
worth emailing about.  Although this one looks like a real bug.  We
should be passing "&pci_handle" to efi_call_phys5 instead of
"pci_handle".

I'm not sure why GCC doesn't warn about these.  Anyway, it's because
GCC didn't warn about unitialized variables that I added it to
Smatch.

> + arch/x86/boot/compressed/eboot.c:303 setup_efi_pci() warn: add some parenthesis here?
> + arch/x86/boot/compressed/eboot.c:303 setup_efi_pci() warn: maybe use && instead of &

These are real but they duplicate Sparse warnings.  :/

>   arch/x86/boot/compressed/eboot.c:728 handle_ramdisks() error: potentially derefencing uninitialized 'fh'.
> 

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux