On 2012-09-09 14:15, Fengguang Wu wrote: > Hi Kent, > > FYI, there are new smatch warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next > head: 5611a9dbd54b993fe24f322a0c310a6605824c0f > commit: 3f86a82aeb03e6100f7ab39f4702e033a5e38166 [7/35] block: Consolidate bio_alloc_bioset(), bio_kmalloc() The logic in there does look both confusing and broken. For !bs, we should not enter the bvec_alloc_bs() part. We already have the vec, plus bvec_alloc_bs() would crap out for !bs. That would exclude us from hitting err_free as well. Style issue on nr_iovecs check, too. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
