On 07/14/2012 06:43 PM, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > Typically, the return value desired for the failure of a function with an > integer return value is a negative integer. In these cases, the return > value is sometimes a negative integer and sometimes 0, due to a subsequent > initialization of the return variable within the loop. > > A simplified version of the semantic match that finds this problem is: > (http://coccinelle.lip6.fr/) > > //<smpl> > @r exists@ > identifier ret; > position p; > constant C; > expression e1,e3,e4; > statement S; > @@ > > ret = -C > ... when != ret = e3 > when any > if@p (...) S > ... when any > if (\(ret != 0\|ret < 0\|ret > 0\) || ...) { ... return ...; } > ... when != ret = e3 > when any > *if@p (...) > { > ... when != ret = e4 > return ret; > } > //</smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> Thanks, applied to can-next Marc > > --- > drivers/net/can/softing/softing_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/can/softing/softing_main.c b/drivers/net/can/softing/softing_main.c > index a7c77c7..f2a221e 100644 > --- a/drivers/net/can/softing/softing_main.c > +++ b/drivers/net/can/softing/softing_main.c > @@ -826,12 +826,12 @@ static __devinit int softing_pdev_probe(struct platform_device *pdev) > goto sysfs_failed; > } > > - ret = -ENOMEM; > for (j = 0; j < ARRAY_SIZE(card->net); ++j) { > card->net[j] = netdev = > softing_netdev_create(card, card->id.chip[j]); > if (!netdev) { > dev_alert(&pdev->dev, "failed to make can[%i]", j); > + ret = -ENOMEM; > goto netdev_failed; > } > priv = netdev_priv(card->net[j]); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-can" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature
