I see the problem, and the solution. You may add Acked-by: Kurt Van Dijck <kurt.van.dijck@xxxxxx> On Sat, Jul 14, 2012 at 06:43:04PM +0200, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > Typically, the return value desired for the failure of a function with an > integer return value is a negative integer. In these cases, the return > value is sometimes a negative integer and sometimes 0, due to a subsequent > initialization of the return variable within the loop. > > A simplified version of the semantic match that finds this problem is: > (http://coccinelle.lip6.fr/) > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > --- > drivers/net/can/softing/softing_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/can/softing/softing_main.c b/drivers/net/can/softing/softing_main.c > index a7c77c7..f2a221e 100644 > --- a/drivers/net/can/softing/softing_main.c > +++ b/drivers/net/can/softing/softing_main.c > @@ -826,12 +826,12 @@ static __devinit int softing_pdev_probe(struct platform_device *pdev) > goto sysfs_failed; > } > > - ret = -ENOMEM; > for (j = 0; j < ARRAY_SIZE(card->net); ++j) { > card->net[j] = netdev = > softing_netdev_create(card, card->id.chip[j]); > if (!netdev) { > dev_alert(&pdev->dev, "failed to make can[%i]", j); > + ret = -ENOMEM; > goto netdev_failed; > } > priv = netdev_priv(card->net[j]); > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
