Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 12, 2012 at 06:19:29PM +0200, walter harms wrote:

> >  	if (ret != 0) {
> >  		dev_err(arizona->dev, "Failed to read MICDET: %d\n", ret);
> > +		mutex_unlock(&info->lock);
> >  		return IRQ_NONE;

> normally you unlock before dev_err() and is the msg ok ?

No, that's really unusual as it can make the trace much harder to follow
if there's any contention.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux