On Thu, Jul 12, 2012 at 06:19:29PM +0200, walter harms wrote: > nitpicking: > normally you unlock before dev_err() and is the msg ok ? > IMHO "Failed to read ARIZONA_MIC_DETECT_3:%d\n" seems more obvious, > (I really do not know that device) > It's not a bad idea if someone wants to send a follow on patch. I just matched the rest of the function. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
