On 12.06.2012 11:37, Marc Kleine-Budde wrote: > On 06/11/2012 07:42 PM, Oliver Hartkopp wrote: >> On 10.06.2012 19:52, Marc Kleine-Budde wrote: >> >>> On 06/09/2012 05:56 PM, Dan Carpenter wrote: >>>> (CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which >>>> is zero so the condition is never true. The intent here was to test >>>> that both flags were set. >>>> >>>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> >>>> --- >>>> This is a static checker fix. I'm not super familiar with the c_can >>>> code. >>> >>> Good catch. Applied to can-next. >>> >>> Marc >>> >> >> >> Shouldn't this fix go through the net-tree and stable instead of net-next? > > Can I add your Acked-by ... when adding to net? Yes you can :-) Oliver -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html