On Sun, Jun 10, 2012 at 05:25:05PM +0200, walter harms wrote: > > > Am 10.06.2012 13:25, schrieb Dan Carpenter: > > CMD_SYNC is zero so the if (cmd->flags & CMD_SYNC) is never true and we > > never check the assertion. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > --- > > v2: enables the assertion even more than v1 (based on feedback from > > Johannes Berg). > > The important part is CMD_SYNC -> CMD_ASYNC Not really, no. I considered Johannes's version for my first patch but I decided to be conservative because I didn't know the code well enough to say what is safe. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html