Am 10.06.2012 13:25, schrieb Dan Carpenter: > CMD_SYNC is zero so the if (cmd->flags & CMD_SYNC) is never true and we > never check the assertion. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > v2: enables the assertion even more than v1 (based on feedback from > Johannes Berg). The important part is CMD_SYNC -> CMD_ASYNC re, wh > > diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c > index e55ec6c..5c04895 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c > +++ b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c > @@ -1259,7 +1259,7 @@ int iwl_dvm_send_cmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd) > * the mutex, this ensures we don't try to send two > * (or more) synchronous commands at a time. > */ > - if (cmd->flags & CMD_SYNC) > + if (!(cmd->flags & CMD_ASYNC)) > lockdep_assert_held(&priv->mutex); > > if (priv->ucode_owner == IWL_OWNERSHIP_TM && > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
