On Tue, 15 May 2012, Dan Carpenter wrote:
On Tue, May 15, 2012 at 04:21:24PM +0200, Arend van Spriel wrote:
On 05/15/2012 11:00 AM, Dan Carpenter wrote:
This is potentially called with NULL pointers, for example, look at
brcmf_c_prec_enq(). Since it's a free() function, probably people
expect it to handle NULL pointers.
Acked-by: Arend van Spriel <arend@xxxxxxxxxxxx>
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c
index b45ab34..3e6405e 100644
Is the diff command filtered properly here. In most patches I usually
see '---' immediatly after the Signed-off-by line.
Yeah. Normally git puts the diffstat there, but my scripts leave
it out. All my patches are tiny anyway. ;)
The documentation says:
The canonical patch message body contains the following:
- A "from" line specifying the patch author.
- An empty line.
- The body of the explanation, which will be copied to the
permanent changelog to describe this patch.
- The "Signed-off-by:" lines, described above, which will
also go in the changelog.
- A marker line containing simply "---".
- Any additional comments not suitable for the changelog.
- The actual patch (diff output).
The --- is not attached to the diffstat, as far as I can see.
julia
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
