On Tue, May 15, 2012 at 04:21:24PM +0200, Arend van Spriel wrote: > On 05/15/2012 11:00 AM, Dan Carpenter wrote: > > This is potentially called with NULL pointers, for example, look at > > brcmf_c_prec_enq(). Since it's a free() function, probably people > > expect it to handle NULL pointers. > > Acked-by: Arend van Spriel <arend@xxxxxxxxxxxx> > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c > > index b45ab34..3e6405e 100644 > > Is the diff command filtered properly here. In most patches I usually > see '---' immediatly after the Signed-off-by line. > Yeah. Normally git puts the diffstat there, but my scripts leave it out. All my patches are tiny anyway. ;) regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html