From: Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx> Date: Mon, 14 May 2012 09:36:55 +0200 > On Saturday 12 May 2012 13:00:03 Dan Carpenter wrote: >> There is a typo in the error checking and "&&" was used instead of "||". >> If skb_header_pointer() returns NULL then it leads to a NULL >> dereference. >> >> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Ack-by: Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx> > >> --- >> Btw, this is new code and Sparse complains about endian bugs. > > Can you give me some hints here, arch , compiler version etc. > I guess it was input to hmark_addr_mask() that complains ? He said what he's using, "sparse", the semantic parser, which is largely arch agnostic. I guarantee you will see the warnings if you run it on your system on this code. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
