On Saturday 12 May 2012 13:00:03 Dan Carpenter wrote: > There is a typo in the error checking and "&&" was used instead of "||". > If skb_header_pointer() returns NULL then it leads to a NULL > dereference. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Ack-by: Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx> > --- > Btw, this is new code and Sparse complains about endian bugs. Can you give me some hints here, arch , compiler version etc. I guess it was input to hmark_addr_mask() that complains ? > > diff --git a/net/netfilter/xt_HMARK.c b/net/netfilter/xt_HMARK.c > index 32fbd73..5817d03 100644 > --- a/net/netfilter/xt_HMARK.c > +++ b/net/netfilter/xt_HMARK.c > @@ -223,7 +223,7 @@ static int get_inner_hdr(const struct sk_buff *skb, int iphsz, int *nhoff) > > /* Not enough header? */ > icmph = skb_header_pointer(skb, *nhoff + iphsz, sizeof(_ih), &_ih); > - if (icmph == NULL && icmph->type > NR_ICMP_TYPES) > + if (icmph == NULL || icmph->type > NR_ICMP_TYPES) > return 0; > > /* Error message? */ > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Regards Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
