On Fri, May 4, 2012 at 4:34 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Thu, May 03, 2012 at 06:27:36PM +0300, Tomas Melin wrote: >> Corrected formatting for several DPRINT messages. >> > > This patch is fine, but eventually these will have to changed to: > > dev_dbg(dev->class_dev, > "adv_pci1710 EDBG: BGN: pci171x_ai_cmdtest(...) err=%d ret=1\n", > err); > Ok, I see. So dev_dbg() should always be preffered for debug printing? Also while we are at it, how strict is the rule that printk:s should include KERN_ facility level statements? are missing facility levels worth patching? regards, Tomas > Or even better they can just be removed after the driver is stable. > It's not worth shifting things around too much if we're just going > to redo it later. > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
