On Thu, May 03, 2012 at 06:27:36PM +0300, Tomas Melin wrote: > Corrected formatting for several DPRINT messages. > This patch is fine, but eventually these will have to changed to: dev_dbg(dev->class_dev, "adv_pci1710 EDBG: BGN: pci171x_ai_cmdtest(...) err=%d ret=1\n", err); Or even better they can just be removed after the driver is stable. It's not worth shifting things around too much if we're just going to redo it later. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html