On Sun, Mar 11, 2012 at 2:14 PM, santosh nayak <santoshprasadnayak@xxxxxxxxx> wrote: > From: Santosh Nayak <santoshprasadnayak@xxxxxxxxx> > > Instead of "in_atomic()", we can use in_interrupt() to check whether > its an interrupt context. What is the benefit? Your change turns clcdfb_sleep() into a ticking bomb. If clcdfb_sleep() is called from an atomic section (e.g. under a spinlock) it will call msleep() and the whole thing explodes... -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
