Dan Carpenter <dan.carpenter@xxxxxxxxxx> schrieb am 17.02.2012 07:44:33:
> Von: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> An: Jan Weitzel <j.weitzel@xxxxxxxxx>
> Kopie: Alexey Dobriyan <adobriyan@xxxxxxxxx>, "David S. Miller"
> <davem@xxxxxxxxxxxxx>, Paul Gortmaker
> <paul.gortmaker@xxxxxxxxxxxxx>, Thomas Meyer <thomas@xxxxxxxx>,
> Danny Kukawka <danny.kukawka@xxxxxxxxx>, netdev@xxxxxxxxxxxxxxx,
> kernel-janitors@xxxxxxxxxxxxxxx
> Datum: 17.02.2012 07:45
> Betreff: [patch] net/ethernet: ks8851_mll: signedness bug in
ks8851_probe()
>
> netdev->irq is unsigned, so it's never less than zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Tested-by: Jan Weitzel <j.weitzel@xxxxxxxxx>
> diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/
> ethernet/micrel/ks8851_mll.c
> index 10d5798..b8104d9 100644
> --- a/drivers/net/ethernet/micrel/ks8851_mll.c
> +++ b/drivers/net/ethernet/micrel/ks8851_mll.c
> @@ -1544,7 +1544,7 @@ static int __devinit ks8851_probe(struct
> platform_device *pdev)
>
> netdev->irq = platform_get_irq(pdev, 0);
>
> - if (netdev->irq < 0) {
> + if ((int)netdev->irq < 0) {
> err = netdev->irq;
> goto err_get_irq;
> }
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
