On 02/17/2012 06:45 AM, Dan Carpenter wrote:
> We should handle the allocation here, if only to keep the static
> checkers happy.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Ah, thanks for noticing it and sorry that I introduced it in the first place.
Applied.
Thanks,
Florian Tobias Schandinat
>
> diff --git a/drivers/video/via/via_aux_edid.c b/drivers/video/via/via_aux_edid.c
> index 03f7a41..754d450 100644
> --- a/drivers/video/via/via_aux_edid.c
> +++ b/drivers/video/via/via_aux_edid.c
> @@ -36,10 +36,13 @@ static void query_edid(struct via_aux_drv *drv)
> unsigned char edid[EDID_LENGTH];
> bool valid = false;
>
> - if (spec)
> + if (spec) {
> fb_destroy_modedb(spec->modedb);
> - else
> + } else {
> spec = kmalloc(sizeof(*spec), GFP_KERNEL);
> + if (!spec)
> + return;
> + }
>
> spec->version = spec->revision = 0;
> if (via_aux_read(drv, 0x00, edid, EDID_LENGTH)) {
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
