>From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] >Sent: Thursday, February 09, 2012 2:50 AM > >The current error handling doesn't work because we flash_part is a u32 >so the checks for negative error codes don't work. I considered making >things signed but I don't know the hardware enough to say if that's a >problem. Really, we don't use the error codes so just returning zero >for all problems is fine. Hi Dan, We can't return 0 from the bnad_get_flash_partition_by_offset() on error as the flash partition 0 is a optrom partition. Also we got comments to return proper Linux error codes as ethtool application expects so. What we can do is change the return type of the bnad_get_flash_partition_by_offset() to int. Thanks, Rasesh -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
