From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Date: Wed, 1 Feb 2012 10:45:26 +0300 > We don't check for NULL consistently in __xfrm6_output(). If "x" were > NULL here it would lead to an OOPs later. I asked Steffen Klassert > about this and he suggested that we remove the NULL check. > > On 10/29/11, Steffen Klassert <steffen.klassert@xxxxxxxxxxx> wrote: >>> net/ipv6/xfrm6_output.c >>> 148 >>> 149 if ((x && x->props.mode == XFRM_MODE_TUNNEL) && >>> ^ >> >> x can't be null here. It would be a bug if __xfrm6_output() is called >> without a xfrm_state attached to the skb. I think we can just remove >> this null check. > > Cc: Steffen Klassert <steffen.klassert@xxxxxxxxxxx> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Applied, thanks Dan. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
