On 01/30/2012 04:01 PM, Dan Carpenter wrote: > On Mon, Jan 30, 2012 at 03:50:05PM +0200, Boaz Harrosh wrote: >> On 01/30/2012 03:44 PM, Dan Carpenter wrote: >>> On Mon, Jan 30, 2012 at 03:37:29PM +0200, Boaz Harrosh wrote: >>>> I think I'd like something like: >>>> - memcpy(odi->systemid, dt_dev->systemid, odi->systemid_len); >>>> + if (likely(odi->systemid_len)) >>>> + memcpy(odi->systemid, dt_dev->systemid, OSD_SYSTEMID_LEN); >>>> >>>> Which should also make the static checkers happy. What do you think? >>>> >>> >>> Sounds good to me. >>> >>> regards, >>> dan carpenter >>> >> >> OK I'll make a patch. Please send your review-by > > Could you give me a Reported-by cookie instead? No one pays any > special attention to Reviewed-by tags when they come from newbies > like me... :P > > regards, > dan carpenter > Sure, yes Boaz -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
