On Mon, Jan 30, 2012 at 03:37:29PM +0200, Boaz Harrosh wrote: > I think I'd like something like: > - memcpy(odi->systemid, dt_dev->systemid, odi->systemid_len); > + if (likely(odi->systemid_len)) > + memcpy(odi->systemid, dt_dev->systemid, OSD_SYSTEMID_LEN); > > Which should also make the static checkers happy. What do you think? > Sounds good to me. regards, dan carpenter
Attachment:
signature.asc
Description: Digital signature