On Wed, Aug 24, 2011 at 12:01:11PM +0200, Rafał Miłecki wrote: > Dan, I asked you to use int in both: call and function declaration. > I'm the author of that code, and I don't have anything against > modifying that :) > > I think int is used much more often that s32 for errors. > No problem. Should I make bcma_erom_get_mst_port() return 0 on success while I'm at it? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html