On Sat, Aug 20, 2011 at 02:23:56PM +0200, Rafał Miłecki wrote: > W dniu 18 sierpnia 2011 15:38 użytkownik Dan Carpenter > <error27@xxxxxxxxx> napisał: > > The u32 would never be less than zero so the error handling would > > break. I changed it to int. > > In declaration we use s32: > static s32 bcma_erom_get_mst_port(struct bcma_bus *bus, u32 **eromptr); > > Doesn't it sound better to use s32 instead of int? > I don't know. I think I'm going to trust the original author on this one. I'll send you a v2 that uses s32. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
