> The for loop was looking for i <= 0 instead of i >= 0 so this
> function never did anything. Also we started with i =
> NB_SYSFS_BIN_FILES instead of "NB_SYSFS_BIN_FILES - 1" which is an
> off by one bug.
>
> Reported-by: Bojan Prtvar <prtvar.b@xxxxxxxxx>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
Acked-by: Jean-François Dagenais <dagenaisj@xxxxxxxxxxxx>
> ---
> v2: fix >= vs <=
>
> diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c
> index c377818..7c8cdb8 100644
> --- a/drivers/w1/slaves/w1_ds2408.c
> +++ b/drivers/w1/slaves/w1_ds2408.c
> @@ -373,7 +373,7 @@ static int w1_f29_add_slave(struct w1_slave *sl)
> static void w1_f29_remove_slave(struct w1_slave *sl)
> {
> int i;
> - for (i = NB_SYSFS_BIN_FILES; i <= 0; --i)
> + for (i = NB_SYSFS_BIN_FILES - 1; i >= 0; --i)
> sysfs_remove_bin_file(&sl->dev.kobj,
> &(w1_f29_sysfs_bin_files[i]));
> }
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
