Yup, confirmed, weird that I did not notice a crash, probably lucky shot in the environment I was using it. On 2011-07-27, at 05:55, Dan Carpenter wrote: > This reads past the end of the w1_f29_sysfs_bin_files[] array. I > don't have this hardware, but I assume it crashes every time the > function is called. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Acked-by: Jean-François Dagenais <dagenaisj@xxxxxxxxxxxx> > > diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c > index c377818..0da4e97 100644 > --- a/drivers/w1/slaves/w1_ds2408.c > +++ b/drivers/w1/slaves/w1_ds2408.c > @@ -373,7 +373,7 @@ static int w1_f29_add_slave(struct w1_slave *sl) > static void w1_f29_remove_slave(struct w1_slave *sl) > { > int i; > - for (i = NB_SYSFS_BIN_FILES; i <= 0; --i) > + for (i = NB_SYSFS_BIN_FILES - 1; i <= 0; --i) > sysfs_remove_bin_file(&sl->dev.kobj, > &(w1_f29_sysfs_bin_files[i])); > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html