On Fri, 22 Jul 2011 12:20:20 -0600 Noah Watkins wrote: > > On Jul 22, 2011, at 12:14 PM, Randy Dunlap wrote: > > > Do those variable names currently cause a problem? > > They are not static, but they also are not exported symbols [EXPORT_SYMBOL()]. > > They are not exported and there are not currently warnings, but it struck me > as inappropriate to have a device specific non-static variable named "devices". > I guess it really might be better to fix later if an actual conflict arises. In general the patches are good -- the variable names are indeed too generic. > Thanks a lot for the note about maintainer reply behavior, I was a little anxious > about sending, but now I'll wait to see what happens. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
