On Wed, 1 Jun 2011, David Miller wrote: > From: Julia Lawall <julia@xxxxxxx> > Date: Wed, 1 Jun 2011 22:08:46 +0200 (CEST) > > > On Wed, 1 Jun 2011, Joe Perches wrote: > > > >> On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote: > >> > The failed_get label is used after the call to clk_get has succeeded, so it > >> > should be moved up above the call to clk_put. > >> [] > >> > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c > >> [] > >> > @@ -978,8 +978,8 @@ static int __devinit flexcan_probe(struct platform_device *pdev) > >> > failed_map: > >> > release_mem_region(mem->start, mem_size); > >> > failed_req: > >> > - clk_put(clk); > >> > failed_get: > >> > + clk_put(clk); > >> > failed_clock: > >> > return err; > >> > >> If this is correct, it might be better to rename all the > >> uses of failed_req to failed_get and delete label failed_req. > > > > As I replied to Walter Harms, I believe it is correct, because I don't see > > anything in the called functions that needs to be freed. I can redo the > > patch to eliminate the label. > > Please do. OK, I will do it tomorrow. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
