On Mon, 2011-05-30 at 21:44 -0300, Rafael Aquini wrote: > Converts all uses of MAC_ADDRESS_COMPARE macro to compare_ether_addr() and delete the macro. [...] Given all the casts you have to add, this doesn't seem like an improvement. How about replacing struct mac_addr with u8[ETH_ALEN] at the same time? You should also be able to get rid of null_mac_addr and use is_zero_ether_addr() instead. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html