> -----Original Message----- > From: linux-fbdev-owner@xxxxxxxxxxxxxxx [mailto:linux-fbdev- > owner@xxxxxxxxxxxxxxx] On Behalf Of Dan Carpenter > Sent: Saturday, March 19, 2011 10:07 AM > To: Paul Mundt > Cc: Guennadi Liakhovetski; Magnus Damm; linux-fbdev@xxxxxxxxxxxxxxx; > kernel-janitors@xxxxxxxxxxxxxxx > Subject: [patch] fbdev: sh_mobile_lcdc: checking NULL instead of IS_ERR() > > backlight_device_register() returns an ERR_PTR. It doesn't return NULL. The patch is not applying on the master branch of fbdev tree. I could find another branch: fbdev/shmobile on the tree. It is a good idea to mention this in the description of the patch. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/drivers/video/sh_mobile_lcdcfb.c > b/drivers/video/sh_mobile_lcdcfb.c > index bf2629f..a53abe1 100644 > --- a/drivers/video/sh_mobile_lcdcfb.c > +++ b/drivers/video/sh_mobile_lcdcfb.c > @@ -1088,7 +1088,7 @@ static struct backlight_device > *sh_mobile_lcdc_bl_probe(struct device *parent, > > bl = backlight_device_register(ch->cfg.bl_info.name, parent, ch, > &sh_mobile_lcdc_bl_ops, NULL); > - if (!bl) { > + if (IS_ERR(bl)) { > dev_err(parent, "unable to register backlight device\n"); How about printing the error number here? > return NULL; Code is not checking for return value where this function is called. A code snippet where this function is called: /* probe the backlight is there is one defined */ if (ch->cfg.bl_info.max_brightness) ch->bl = sh_mobile_lcdc_bl_probe(&pdev->dev, ch); If the return value is not checked then whats the use of return value? > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
