Hi Dan
On Sun, 20 Mar 2011, Dan Carpenter wrote:
> This function is designed to accept a NULL for "best_freq" but the
> debug code dereferences it unconditionally.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> ---
> Btw. Smatch complains that "best" could NULL as well, but I don't
> know if actually that's possible so I left it as is.
>
> diff --git a/drivers/sh/clk/core.c b/drivers/sh/clk/core.c
> index 5f63c3b..dee971c 100644
> --- a/drivers/sh/clk/core.c
> +++ b/drivers/sh/clk/core.c
> @@ -616,7 +616,7 @@ long clk_round_parent(struct clk *clk, unsigned long target,
>
> pr_debug("%u / %lu = %lu, / %lu = %lu, best %lu, parent %u\n",
> freq->frequency, div, freq_high, div + 1, freq_low,
> - *best_freq, best->frequency);
> + best_freq ? *best_freq : -1, best->frequency);
What about another occasion of dereferencing best_freq at the top of the
clk_round_parent() function:
if (!parent) {
*parent_freq = 0;
*best_freq = clk_round_rate(clk, target);
return abs(target - *best_freq);
}
?
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
