> Julia is correct. Some architectures can return NULL from clk_get, but I > didn't check the at91 before posting :-/. If we can't return NULL from > clk_get then we shouldn't bother checking for it. I do think we should > drop the !IS_ERR(clk_get(dev, func)) check though. It seems a bit subtle, because the clk manipulated by clk_get in the call of clk_get(dev, func) is not necessarily the same as the one in clock_associate. But perhaps this is the only possibility in practice? julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html