On Mon, Jan 10, 2011 at 09:58:32AM +0200, Rémi Denis-Courmont wrote: > On Friday 07 January 2011 22:37:55 ext Dan Carpenter, you wrote: > > Dan Rosenberg pointed out that there were some signed comparison bugs > > in the phonet protocol. > > There are two ways to solve this: change *only* the proto_get function to use > an unsigned parameter, or cast the protocol to unsigned in the comparison. > > As David pointed out, your patch breaks the socket() callback prototype. > Yes. I really appologize for that. I'll send version 2 with that create() change dropped. It's not needed. I would like to keep the change to phonet_proto_register() because the check in there isn't right and it's similar to phonet_proto_get(). We may as well keep phonet_proto_unregister() as well so it's symmetric. Let me know if you disagree and I'll redo it. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
