On Friday 07 January 2011 22:37:55 ext Dan Carpenter, you wrote: > Dan Rosenberg pointed out that there were some signed comparison bugs > in the phonet protocol. There are two ways to solve this: change *only* the proto_get function to use an unsigned parameter, or cast the protocol to unsigned in the comparison. As David pointed out, your patch breaks the socket() callback prototype. -- Rémi Denis-Courmont Nokia Devices R&D, Maemo Software, Helsinki -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html