Re: [patch -next] lockd: double unlock in next_host_state()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 03, 2011 at 10:59:36AM -0500, Chuck Lever wrote:
> > -			mutex_unlock(&nlm_host_mutex);
> > 			goto out;
> > 		}
> > 	}
> 
> Would it also make sense to replace the "goto out;" with a "break;" ?

No.  for_each_host() is a nested for loop, so a break would only take
you out of the inner most loop.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux