On Jan 2, 2011, at 3:20 PM, Dan Carpenter wrote: > We unlock again after we goto out. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/fs/lockd/host.c b/fs/lockd/host.c > index c106d6a..5f1bcb2 100644 > --- a/fs/lockd/host.c > +++ b/fs/lockd/host.c > @@ -532,7 +532,6 @@ static struct nlm_host *next_host_state(struct hlist_head *cache, > host->h_state++; > > nlm_get_host(host); > - mutex_unlock(&nlm_host_mutex); > goto out; > } > } Would it also make sense to replace the "goto out;" with a "break;" ? -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
