On Tue, Sep 28, 2010 at 09:49:35PM +0400, Vasiliy Kulikov wrote: > ft1000_copy_up_pkt() doesn't free skb on errors. > init_ft1000_card() doesn't free netdev with free_netdev() but with kfree(). > init_ft1000_card() doesn't check request_region()'s return value > and doesn't free region on error. > > Signed-off-by: Vasiliy Kulikov <segooon@xxxxxxxxx> > --- > Compile tested. No you didn't > drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 32 +++++++++++++-------- > 1 files changed, 20 insertions(+), 12 deletions(-) This file doesn't build at this point in time, how did you build test this? I don't mind taking the patch, but please, don't lie. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html