On Sat, Sep 25, 2010 at 12:44:52PM +0200, walter harms wrote: > > > Tracey Dent schrieb: > > Changed to use proper ccflags-y option > > > > Signed-off-by: Tracey Dent <tdent48227@xxxxxxxxx> > > --- > > drivers/staging/rtl8187se/Makefile | 20 ++++++++++---------- > > 1 files changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/staging/rtl8187se/Makefile b/drivers/staging/rtl8187se/Makefile > > index e6adf91..51fbd24 100644 > > --- a/drivers/staging/rtl8187se/Makefile > > +++ b/drivers/staging/rtl8187se/Makefile > > @@ -1,20 +1,20 @@ > > > > -#EXTRA_CFLAGS += -DCONFIG_IEEE80211_NOWEP=y > > -#EXTRA_CFLAGS += -std=gnu89 > > -#EXTRA_CFLAGS += -O2 > > +#ccflags-y := -DCONFIG_IEEE80211_NOWEP=y > > +#ccflags-y := -std=gnu89 > > +#ccflags-y := -O2 > > #CC = gcc > > > > -EXTRA_CFLAGS += -DSW_ANTE > > -EXTRA_CFLAGS += -DTX_TRACK > > -EXTRA_CFLAGS += -DHIGH_POWER > > -EXTRA_CFLAGS += -DSW_DIG > > -EXTRA_CFLAGS += -DRATE_ADAPT > > +ccflags-y := -DSW_ANTE > > +ccflags-y := -DTX_TRACK > > +ccflags-y := -DHIGH_POWER > > +ccflags-y := -DSW_DIG > > +ccflags-y := -DRATE_ADAPT > > > > #enable it for legacy power save, disable it for leisure power save > > -EXTRA_CFLAGS += -DENABLE_LPS > > +ccflags-y := -DENABLE_LPS > > > > > > -#EXTRA_CFLAGS += -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y > > +#ccflags-y := -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y > > > > I do not understand this. If CONFIG_FORCE_HARD_FLOAT is required by the > driver so he should fail if CONFIG_FORCE_HARD_FLOAT=n > Or you need to protect the -mhard-float with an if(). That line is commented out, it doesn't do anything, so I wouldn't worry about it :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
