Re: [patch] cciss: freeing uninitialized data on error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2010-09-12 01:39, Dan Carpenter wrote:
> The "h->scatter_list" is allocated inside a for loop.  If any of those
> allocations fail, then the rest of the list is uninitialized data.  When
> we free it we should start from the top and free backwards so that we
> don't call kfree() on uninitialized pointers.
> 
> Also if the allocation for "h->scatter_list" fails then we would get an
> Oops here.  I should have noticed this when I send: 4ee69851c "cciss:
> handle allocation failure."  but I didn't.  Sorry about that.

Thanks Dan, applied.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux