On Wed, 2010-09-08 at 21:39 +0200, Dan Carpenter wrote: > If "ur_idx" is wrong we could go past the end of the array. The > "ur_idx" comes from root so it's not a huge deal, but adding a sanity > check makes the code more robust. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c > index a825002..9c00549 100644 > --- a/drivers/mtd/mtdchar.c > +++ b/drivers/mtd/mtdchar.c > @@ -513,6 +513,9 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg) > if (get_user(ur_idx, &(ur->regionindex))) > return -EFAULT; > > + if (ur_idx >= mtd->numeraseregions) > + return -EINVAL; > + Pushed to l2-mtd-2.6.git with my "Signed-off-by", thanks. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
