2010/8/7 Rafał Miłecki <zajec5@xxxxxxxxx>: > 2010/8/8 Dan Carpenter <error27@xxxxxxxxx>: >> Smatch complained that the ERR_PTR from hwmon_device_register() wasn't >> handled. I added some error handling in radeon_hwmon_init() to silence >> the warning. >> >> Unfortunately errors from radeon_pm_init() aren't handled so this >> doesn't really make a difference beyond silencing the warning. >> >> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > Didn't we try to switch from DRM_ERROR to dev_err? I think that's > preferred method. Other than that, the patch looks fine. Reviewed-by: Alex Deucher <alexdeucher@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
