On Mon, 9 Aug 2010, Desai, Kashyap wrote: > > > > -----Original Message----- > > From: Dan Carpenter [mailto:error27@xxxxxxxxx] > > Sent: Friday, August 06, 2010 1:29 PM > > To: Julia Lawall > > Cc: James E.J. Bottomley; linux-scsi@xxxxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx; Moore, Eric; > > Desai, Kashyap > > Subject: [PATCH] scsi: mpt2sas: Add space in printk > > > > Add a space in the output: > > old: Discovery: (stop)discovery_status(0x%08x) > > new: Discovery: (stop) discovery_status(0x%08x) > > > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > --- > > This goes on top of Julia's [PATCH 9/42] drivers/scsi: Adjust > > confusing if indentation > > > > diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c > > b/drivers/scsi/mpt2sas/mpt2sas_base.c > > index 12faf64..562b909 100644 > > --- a/drivers/scsi/mpt2sas/mpt2sas_base.c > > +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c > > @@ -532,7 +532,7 @@ _base_display_event_data(struct MPT2SAS_ADAPTER > > *ioc, > > (event_data->ReasonCode == > > MPI2_EVENT_SAS_DISC_RC_STARTED) ? > > "start" : "stop"); > > if (event_data->DiscoveryStatus) > > - printk("discovery_status(0x%08x)", > > + printk(" discovery_status(0x%08x)", > I don't see any significant reason for changing print. It not adding any benefit. It would look a little nicer to have a space after the ) that is printed by the previous statement. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
