On Sat, Jul 24, 2010 at 10:59:07AM +0200, walter harms wrote: > IMHO it would be better to make sure that pd->t_clk,pd->tx_csum_limit > have usefull values than adding a check but this is up to the maintainer. I don't see the point of that at all. We check against zero to see whether the caller bothered to fill in the field at all, but if the caller wants to pass in bogus values, that's up to the caller. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html