On Fri, Jul 23, 2010 at 06:30:22PM +0200, walter harms wrote: > this is a bit complicated, IMHO ppl have a bigger chance to discover what is going on > with this version: > > if (!pd ) { > msp->t_clk = 133000000; > msp->tx_csum_limit = 9 * 1024; > } > else > { > msp->t_clk = pd->t_clk ? pd->t_clk : 133000000 ; > msp->tx_csum_limit = pd->tx_csum_limit ? pd->tx_csum_limit : 9 * 1024; > } > But then instead of 2 magic numbers we would have 4. :/ regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html