On Thu, 2010-07-15 at 18:07 -0400, Jarod Wilson wrote: > On Thu, Jul 15, 2010 at 5:43 PM, Andy Walls <awalls@xxxxxxxxxxxxxxxx> wrote: > > On Thu, 2010-07-15 at 21:08 +0200, Peter Huewe wrote: > >> From: Peter Huewe <peterhuewe@xxxxxx> > > a. PCI_ANY_ID indicates to the reader a wildcard match is being > > performed. The PCI_VDEVICE() macro hides that to some degree. > > > > b. PCI_VENDOR_ID_ICOMP clearly indicates that ICOMP is a vendor. > > "ICOMP" alone does not hint to the reader that is stands for a company > > (the now defunct "Internext Compression, Inc."). > > Personally, I'm a fan of comments around things like this to describe > *exactly* what device(s) they're referring to. Something like this then for ivtv: /* Claim every iTVC15/CX23415 or CX23416 based PCI Subsystem ever made */ ? > Then ICOMP being all > alone without the prefix isn't really much of an issue (though it > could still be easily mistaken for something other than a pci vendor > id, I suppose). Probably not. Another minor side effect is that it breaks a tag search for easily jumping to the definition to see the ID value. "ICOMP" won't be in the tags file, but "PCI_VENDOR_ID_ICOMP" will be. Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
