On Thu, Jul 15, 2010 at 5:43 PM, Andy Walls <awalls@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2010-07-15 at 21:08 +0200, Peter Huewe wrote: >> From: Peter Huewe <peterhuewe@xxxxxx> >> >> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and >> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the >> PCI_VDEVICE macro, and thus improves readability. > > Hi Peter, > > I have to disagree. The patch may improve typesetting, but it degrades > clarity and maintainability from my perspective. > > a. PCI_ANY_ID indicates to the reader a wildcard match is being > performed. The PCI_VDEVICE() macro hides that to some degree. > > b. PCI_VENDOR_ID_ICOMP clearly indicates that ICOMP is a vendor. > "ICOMP" alone does not hint to the reader that is stands for a company > (the now defunct "Internext Compression, Inc."). Personally, I'm a fan of comments around things like this to describe *exactly* what device(s) they're referring to. Then ICOMP being all alone without the prefix isn't really much of an issue (though it could still be easily mistaken for something other than a pci vendor id, I suppose). -- Jarod Wilson jarod@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
